Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoginFile class + dependencies #154

Merged
merged 20 commits into from
Feb 11, 2019
Merged

Add LoginFile class + dependencies #154

merged 20 commits into from
Feb 11, 2019

Conversation

sisou
Copy link
Member

@sisou sisou commented Dec 15, 2018

Since I was experimenting with the old-style backup file in the beginning, this PR also includes some improvements to the Iqons class.

Also includes @danimoh's QRScanner improvements that enable scanning an inverted QRCode.

This PR does not include changes required to encode the new Imagewallet standard. This will happen in a separate PR (#155).

@sisou sisou self-assigned this Dec 15, 2018
@sisou sisou mentioned this pull request Jan 4, 2019
40 tasks
demos/LoginFile.html Show resolved Hide resolved
src/components/FileImport.js Show resolved Hide resolved
src/lib/Iqons.js Show resolved Hide resolved
src/lib/LoginFile.js Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
tests/lib/LoginFile.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@nibhar nibhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are only about a variable name, and some annotations.

src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
src/lib/LoginFile.js Outdated Show resolved Hide resolved
@sisou sisou merged commit c75816e into master Feb 11, 2019
@sisou sisou deleted the soeren/wallet-file branch February 11, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants