Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up the code a bit, make a better number recognition. #50

Closed
wants to merge 1 commit into from
Closed

Speed up the code a bit, make a better number recognition. #50

wants to merge 1 commit into from

Conversation

fabianblum
Copy link

With '' === $cellValue the code is a bit faster because there is no strlen calculation needed
is_nummeric is a better number recognition in this case because is_int and is_float does not recognize $var = "123456"as a number

@fabianblum
Copy link
Author

Nvm, i think the typ declaration should made out of the process

@fabianblum fabianblum closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant