Add faraday matrix to CI #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional gemfiles in the gemfiles/ directory for exercising tests against the minimum supported version of Faraday 0.11 and the most recent supported Faraday version < 2. Now bin/setup will install gems for each gemfile and the current Ruby. To run tests against Faraday 0.11 for example, one would run: BUNDLE_GEMFILE=gemfile/faraday0.gemfile bundle exec rspec
rossta
force-pushed
the
chore/faraday-matrix
branch
from
38ca81b
to
523bb21
Compare
thde
reviewed
Sep 28, 2023
| @@ -0,0 +1,95 @@ | |||
| PATH | |||
There was a problem hiding this comment.
TIL 😄
The presence of a Gemfile.lock in a gem’s repository ensures that a fresh checkout of the repository uses the exact same set of dependencies every time.
thde
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
netbox-client-rubysupports Faraday 0.11.x up to 1.x. Faraday 2 has been out since Jan 2022. There are some incompatibilities across this range of Faraday versions, e.g. Faraday 0.x does not appear to work with Ruby 3.x. Only Faraday 1.x is tested on CI and there is not currently a strategy to test multiple Faraday versions.Solution
Adopt a Gemfile matrix for CI to test multiple versions of Faraday against multiple versions of Ruby from 2.7-3.2.
This change adds additional gemfiles in the gemfiles/ directory for exercising tests against the minimum supported version of Faraday 0.11 and the most recent supported Faraday 1.x version. This also enables change I have in progress to add support for Faraday 2.x #65.
Now
bin/setupwill install gems for each gemfile and the current Ruby.To run tests against Faraday 0.x for example, one would run: