Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metascore integration #14

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jorgenbuilder
Copy link

So, we have this project to be a leaderboard hub / aggregator for IC games. This PR integrates the reversi game in Metascore. This is more of a proposal than a ready-to-ship PR: canister ids shouldn't be overwritten in any final PR, and I haven't tested how the upgrade would affect state.

It would be great to get this integration in, so that everyones' existing high scores could make their way into Metascore!

@ninegua
Copy link
Owner

ninegua commented Sep 22, 2021

This is an interesting PR. Thanks!

The changes to deliver scores to Metascore looks a bit invasive to me. Will it be possible to use a pull model instead of push?

Also it seems to rely on a critical assumption "a user has the same principal across multiple games" to make this work. Am I reading it correctly?

@jorgenbuilder
Copy link
Author

jorgenbuilder commented Sep 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants