-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metascore integration #14
Draft
jorgenbuilder
wants to merge
8
commits into
ninegua:master
Choose a base branch
from
jorgenbuilder:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an interesting PR. Thanks! The changes to deliver scores to Metascore looks a bit invasive to me. Will it be possible to use a pull model instead of push? Also it seems to rely on a critical assumption "a user has the same principal across multiple games" to make this work. Am I reading it correctly? |
Yes, we support pull and push. At the moment pulls are very infrequent, so
push is just better for being up to date.
Yes common principal across cans is critical. The Stoic wallet provides
that in this PR. Metascore also supports plug.
We are currently running this code in our own canisters, which you can see
by going to metascore.one
Not sure if it would make sense to merge these changes to your upstream,
but wanted to give you a heads up, and would be happy to help get this PR
in a better state if you wanted to merge!
…On Wed, Sep 22, 2021 at 4:09 PM Paul Liu ***@***.***> wrote:
This is an interesting PR. Thanks!
The changes to deliver scores to Metascore looks a bit invasive to me.
Will it be possible to use a pull model instead of push?
Also it seems to rely on a critical assumption "a user has the same
principal across multiple games" to make this work. Am I reading it
correctly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQ5SUMUNB6ZQTMCGQWF2LDUDJOZTANCNFSM5EFUE2LA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, we have this project to be a leaderboard hub / aggregator for IC games. This PR integrates the reversi game in Metascore. This is more of a proposal than a ready-to-ship PR: canister ids shouldn't be overwritten in any final PR, and I haven't tested how the upgrade would affect state.
It would be great to get this integration in, so that everyones' existing high scores could make their way into Metascore!