send resp_headers with websocket responses #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like it got removed by mistake indeed. Please add a test to ws_SUITE so it doesn't happen again. |
|
Alright. Let me know if that looks ok. |
|
Thanks, will try to remember this PR tomorrow. :-) |
|
Merged with tweaks, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is needed to support subprotocol negotiation (with the
Sec-WebSocket-Protocolheader) and sending cookies (with theCookieheader) in websockets as outlined in the spec, section 1.3. It looks like it was supported in Cowboy v1, according to #672.