Run Python garbage collector when an interpreter is closed. #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndjensen
reviewed
Sep 5, 2024
| @@ -703,6 +703,7 @@ void pyembed_thread_close(JNIEnv *env, intptr_t _jepThread) | |||
| Py_DECREF(key); | |||
|
|
|||
| Py_CLEAR(jepThread->globals); | |||
| PyGC_Collect(); | |||
There was a problem hiding this comment.
Just curious, why do you the gc collect call before the Py_EndInterpreter?
There was a problem hiding this comment.
It's not specifically documented for PyGC_Collect but my default assumption for any Python c-api call is that it requires the thread to have an interpreter or at least hold the GIL and after Py_EndInterpreter the thread has neither.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will run Python Garbage Collection anytime an interpreter is closed.
#555 describes a simple use case where reference counting alone is unable to free memory in a jep interpreter on close and running the garbage collector cleans up the memory.
There is a potential downside that this will make close slower in some cases however it should be negligible in most cases and I believe the benefit of freeing memory promptly is worth the extra time in close().