Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output exit code in FAILED message #1805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schultetwin1
Copy link

This fixes #1507

Outputs the exit code after "FAILED" for any process that did not
complete successfully.

Output looks like "FAILED (<exitcode>): <outputs>"

@schultetwin1
Copy link
Author

I'm not complete happy with the interface of this design (putting the exit code in parens). I'd love to hear other ideas if people have them.

Outputs the exit code after "FAILED" for any process that did not
complete successfully.

Output looks like "FAILED (<exitcode>): <outputs>"
@jonatino
Copy link

Any idea when or if this will be merged? It would help a lot when using ninja on CI to have proper sucess/errors. Right now I depend on checking the output to see if the build is there to determine if a ninja subprocess failed or not.

@lazka
Copy link

lazka commented Jun 18, 2022

I was just needing this to debug a failing command that didn't have any output and used this rebased on top of the last release (some code has moved, but the basics still apply). Would indeed be nice to have this by default.

@FrancoisBeaune
Copy link

Adding a vote to merge this PR, or another one that addresses the problem. It would have been very useful to us for debugging random command failures.

@jhasse jhasse added this to the 2.0.0 milestone Apr 14, 2024
@z2oh
Copy link

z2oh commented Sep 25, 2024

Just used a custom built ninja with this patch to debug a gnarly compiler crash. Adding my vote to have this feature merged!

@mcprat
Copy link
Contributor

mcprat commented Sep 26, 2024

it's a great idea, but I don't think this is the best way to write it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ninja hides the exit status of failing subprocesses
7 participants