Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for "module" and "exports" #1

Merged
merged 1 commit into from
May 10, 2017
Merged

Better support for "module" and "exports" #1

merged 1 commit into from
May 10, 2017

Conversation

gimenete
Copy link

@gimenete gimenete commented May 9, 2017

No description provided.

@ninjaprawn
Copy link
Owner

Sorry for the late review, but looks good! TIL about how var module = { exports } automatically expands to {"exports": exports}

@ninjaprawn ninjaprawn merged commit 6a8edd8 into ninjaprawn:master May 10, 2017
@amilajack amilajack mentioned this pull request Mar 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimenete @ninjaprawn