Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared roster groups #63

Closed
poVoq opened this issue Aug 20, 2022 · 12 comments · Fixed by #90
Closed

Shared roster groups #63

poVoq opened this issue Aug 20, 2022 · 12 comments · Fixed by #90
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@poVoq
Copy link

poVoq commented Aug 20, 2022

ejabberd and prosody (via https://prosody.im/doc/modules/mod_groups) support configuring shared nested roster groups and it would be nice if the UI would support this by showing the roster categories as groups of contacts.

As xmpp-web doesn't do contact management by itself (for now?) I think this would be used often by linking these groups to LDAP for example.

@poVoq poVoq added the enhancement New feature or request label Aug 20, 2022
@nioc nioc added the need repro This issue requires a specific setup to reproduce it label Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This issue will be closed within two weeks if the requested reproduction data is not provided. Please refer to this guide.

@github-actions github-actions bot added the stale This could be dismissed soon label Feb 8, 2023
@poVoq
Copy link
Author

poVoq commented Feb 8, 2023

@nioc
Copy link
Owner

nioc commented Feb 8, 2023

Thanks @poVoq unfortunately, I'm not using eJabberd and the staging setup is based on Prosody, can you provide a prosody.cfg file I can use?

@poVoq
Copy link
Author

poVoq commented Feb 8, 2023

An example for Prosody is in the original post. Prosody's support is much more limited, but you can make a sharedgroups.txt and enable and point mod_groups to it.

@nioc
Copy link
Owner

nioc commented Feb 8, 2023

Seriously, I don't want to spend my free time trying to figure out how to reproduce setup. I have already spent time to make a detailed procedure, and and no one cares... WHAT IS NOT CLEAR?
I'm waiting the archive, it only takes 5 minutes to do... it was the last time.

63-poVoq-reproducing-setup.tar.gz

@nioc
Copy link
Owner

nioc commented Feb 8, 2023

Now I can reproduce, what is your need?
If UI display something like the following, is it ok?
image

@nioc
Copy link
Owner

nioc commented Feb 8, 2023

Bad idea. As a user can be in more than one group, it will be too long.

@poVoq
Copy link
Author

poVoq commented Feb 8, 2023

Sure, was just an idea. Thanks for looking into it!

@poVoq poVoq closed this as completed Feb 8, 2023
@nioc
Copy link
Owner

nioc commented Feb 8, 2023

I do not give up 😠
This is more in your first idea:

image

I am right?

@nioc nioc reopened this Feb 8, 2023
@nioc nioc removed need repro This issue requires a specific setup to reproduce it stale This could be dismissed soon labels Feb 8, 2023
@nioc
Copy link
Owner

nioc commented Feb 8, 2023

When I said "Bad idea", it was my UI proposal I was talking about 😉

@poVoq
Copy link
Author

poVoq commented Feb 9, 2023

Your second example is how ConverseJS does it. To me that seems like a good way to do it.

@nioc
Copy link
Owner

nioc commented Feb 9, 2023

Great! I let it as pull request for now, if you want some UI tweaks, let me know.

@nioc nioc added this to the 0.9.10 milestone Feb 9, 2023
@nioc nioc self-assigned this Feb 9, 2023
@nioc nioc closed this as completed in #90 Feb 9, 2023
nioc added a commit that referenced this issue Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants