Add url in body of oob messages #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>
|
Hello @Ppjet6, thanks for this proposal. I'll look at it this week-end. Your change seems straightfoward, but I prefer to check it before merging 😉 |
|
As you made me opening code for others issues, I check this one too and you were right (may be a regression since the move from Stanza to @xmpp/client in 0458da7) |
|
0.9.4 released and pushed on dockerhub 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing http uploading images sent as OOB messages. I'm submitting this because I noticed multiple clients aren't displaying images when sent from xmpp-web.
https://docs.modernxmpp.org/client/protocol/#communicating-the-url
I have to admit I haven't tested this change but it seems rather straightfoward. This does means that a body can't be provided alongside a URL.
Signed-off-by: Maxime “pep” Buquet pep@bouah.net