Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Document the fact that we are using popylar/GA for usage tracking. #63

Merged
merged 5 commits into from
Jan 16, 2020
Merged

DOC: Document the fact that we are using popylar/GA for usage tracking. #63

merged 5 commits into from
Jan 16, 2020

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Jan 16, 2020

Adds some documentation about our use of popylar.

@pull-assistant
Copy link

pull-assistant bot commented Jan 16, 2020 •
edited
Loading

Score: 0.88

Best reviewed: commit by commit

Optimal code review plan

     DOC: Document the fact that we are using popylar/GA for usage tracking...

     PEP8: remove extraneous whitespace.

     Removes whitespace in rst.

     Update docs/usage.rst

     Update docs/usage.rst

Powered by Pull Assistant. Last update 90a4786 ... 055e36c. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jan 16, 2020 •
edited
Loading

Hello @arokem, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 dmriprep.

Comment last updated at 2020-01-16 18:21:00 UTC

@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #63 into master will increase coverage by 0.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   52.37%   52.71%   +0.34%     
==========================================
  Files          16       16              
  Lines         907      901       -6     
  Branches      114      111       -3     
==========================================
  Hits          475      475              
+ Misses        431      425       -6     
  Partials        1        1
Impacted Files Coverage Δ
dmriprep/cli/run.py 31.08% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127a65d...055e36c. Read the comment docs.

oesteban
oesteban approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nit-picks

docs/usage.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated Show resolved Hide resolved
arokem and others added 3 commits January 16, 2020 10:19
@arokem
Removes whitespace in rst.
70c99fb
@arokem @oesteban
Update docs/usage.rst
633f36f 
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
@arokem @oesteban
Update docs/usage.rst
055e36c 
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
@oesteban
Copy link
Member

Just a heads-up: using docs/popylar as branch name (instead of docs_popylar) would've triggered just the build_docs job 👍

@oesteban oesteban merged commit 67e57ae into nipreps:master Jan 16, 2020
@arokem arokem deleted the docs_popylar branch January 16, 2020 18:30
@arokem
Copy link
Collaborator Author

arokem commented Jan 16, 2020

Wow. So many things to remember!

@oesteban
Copy link
Member

Unfortunately yes :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arokem @pep8speaks @oesteban