Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add general crediting system #32

Merged
merged 2 commits into from
Apr 12, 2021
Merged

ENH: Add general crediting system #32

merged 2 commits into from
Apr 12, 2021

Conversation

oesteban
Copy link
Member

No description provided.

@pep8speaks
Copy link

pep8speaks commented Apr 12, 2021

Hello @oesteban! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 80:24: E741 ambiguous variable name 'l'
Line 89:13: W503 line break before binary operator

Comment last updated at 2021-04-12 09:45:58 UTC

@oesteban oesteban marked this pull request as ready for review April 12, 2021 09:46
@oesteban oesteban merged commit f5de640 into main Apr 12, 2021
@oesteban oesteban deleted the enh/credits branch April 22, 2021 09:21
arokem pushed a commit that referenced this pull request Jun 24, 2022
ENH: Add general crediting system
Former-commit-id: f5de640
Former-commit-id: 7697df0
arokem pushed a commit that referenced this pull request Jun 24, 2022
ENH: Add general crediting system
Former-commit-id: b17a1a3 [formerly f5de640]
Former-commit-id: 7697df0
Former-commit-id: ba4e6be
mathdugre pushed a commit to mathdugre/eddymotion that referenced this pull request Jun 24, 2022
ENH: Add general crediting system
mathdugre pushed a commit to mathdugre/eddymotion that referenced this pull request Jun 24, 2022
ENH: Add general crediting system
oesteban added a commit that referenced this pull request Jun 30, 2022
ENH: Add general crediting system
Former-commit-id: f5de640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants