ENH: Adapt fMRIPrep to upcoming sMRIPrep API changes #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
oesteban
force-pushed
the
fix/smriprep-167-api-change
branch
from
71266cb
to
264ce92
Compare
In particular, nipreps#167 introduces a few changes that need to be considered before nipreps#1829 is merged.
oesteban
force-pushed
the
fix/smriprep-167-api-change
branch
from
264ce92
to
1236b1d
Compare
|
This build should be ready to pass. Comments are welcome :) |
Yup. The option and a new line in the config module for this option. |
mgxd
reviewed
Mar 17, 2020
| omp_nthreads=config.nipype.omp_nthreads, | ||
| output_dir=str(config.execution.output_dir), | ||
| reportlets_dir=reportlets_dir, | ||
| skull_strip_fixed_seed=config.workflow.skull_strip_fixed_seed, | ||
| # skull_strip_mode='force', | ||
| skull_strip_mode='force', |
There was a problem hiding this comment.
surely this will have a config option?
There was a problem hiding this comment.
yes (we are talking about that right now in #1829 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, #167 introduces a few changes that need to be considered before #1829 is merged:
skull_strip_modeargument for the anatomical workflow (ENH: Add option to skip brain extraction smriprep#167)