Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Move away from nearly deprecated images #2295

Merged
merged 1 commit into from
Oct 2, 2020
Merged

MAINT: Move away from nearly deprecated images #2295

merged 1 commit into from
Oct 2, 2020

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Oct 1, 2020

Closes #2293

@pull-assistant
Copy link

pull-assistant bot commented Oct 1, 2020

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     MAINT: Move away from nearly deprecated images

Powered by Pull Assistant. Last update aa64659 ... aa64659. Read the comment docs.

@effigies
Copy link
Member

effigies commented Oct 1, 2020

🤞

@mgxd mgxd marked this pull request as ready for review October 1, 2020 22:01
@mgxd
Copy link
Collaborator Author

mgxd commented Oct 1, 2020

This transition looks to not cause any major ripples

@effigies
Copy link
Member

effigies commented Oct 1, 2020

Let's do it.

@mgxd mgxd merged commit d288ee2 into nipreps:master Oct 2, 2020
@mgxd mgxd deleted the ci/dep-images branch October 2, 2020 02:30
@effigies
Copy link
Member

This should be safe to apply to maint/20.2.x, right? We should probably do that.

@mgxd
Copy link
Collaborator Author

mgxd commented Oct 15, 2020

yes - should we open a new PR or just cherry-pick this?

@effigies
Copy link
Member

I'm okay cherry-picking if you are.

@mgxd mgxd mentioned this pull request Nov 9, 2020
Merged
@effigies effigies mentioned this pull request Dec 12, 2020
Merged
@mgxd
Copy link
Collaborator Author

mgxd commented Apr 22, 2021

And now I'm realizing I forgot to do this for the LTS branch - done in #2400 just to get CI going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: CircleCI deprecating images we are using currently
2 participants
@mgxd @effigies