MAINT: Revise CircleCI's cache tags to avoid mixups between builds #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of the ambiguity of these tags, a tag 20.2.2 was deployed to docker hub containing the 20.1.4 build last Friday.
The misuse of ``{{ epoch }}`` as well as too liberal template matching when loading cached docker images resulted in this situation.
Resolves: #2454.
|
Any obvious problem / caveat? |
|
Seems to be working properly. Pushing it in. |
|
Do we need to do a similar thing in |
|
Not sure it is worth the pain, but if we again are releasing two tags at once this could possibly happen again. EDIT: yes, the cost is minimal - I can do it |
oesteban
added a commit
to oesteban/dmriprep
that referenced
this pull request
Aug 30, 2021
oesteban
added a commit
to oesteban/dmriprep
that referenced
this pull request
Aug 30, 2021
oesteban
added a commit
to oesteban/dmriprep
that referenced
this pull request
Aug 30, 2021
oesteban
added a commit
to oesteban/dmriprep
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of the ambiguity of these tags, a tag 20.2.2 was deployed to docker hub containing the 20.1.4 build last Friday.
The misuse of
{{ epoch }}as well as too liberal template matching when loading cached docker images resulted in this situation.Resolves: #2454.
Changes proposed in this pull request
Documentation that should be reviewed