Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Clarify that res-2 entity does not mean 2mm #2466

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

oesteban
Copy link
Member

@bbfrederick brought up the problem that, although the documentation does not state the above explicitly, it is the most plausible reading.

This PR adds a danger admonition to clarify the ambiguity.

Follow-up: templateflow/templateflow#92.
Resolves: #1847.

@bbfrederick brought up the problem that, although the documentation
does not state the above explicitly, it is the most plausible reading.

This PR adds a danger admonition to clarify the ambiguity.

Follow-up: templateflow/templateflow#92.
Resolves: #1847.
Co-authored-by: Blaise Frederick <blaise.frederick@gmail.com>
@oesteban
Copy link
Member Author

@bbfrederick I took the liberty of setting you as a reviewer for this PR, please let me know if you would like I keep doing so sparingly.

That said, given the small size of the changes, we might go ahead with it soon if you can't find a moment to check (or are on vacation, which is also highly likely at this point of the year).

Copy link
Contributor

@bbfrederick bbfrederick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is quite clear.

@oesteban oesteban merged commit 934f41b into maint/20.2.x Jul 20, 2021
@oesteban oesteban deleted the docs/1847-spaces branch July 20, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants