-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Run pytest through GitHub actions #2529
Conversation
ff019b1
to
cd376ba
Compare
cd376ba
to
5de40e7
Compare
01bcc1b
to
17ad16c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
=========================================
Coverage ? 44.81%
=========================================
Files ? 41
Lines ? 3088
Branches ? 0
=========================================
Hits ? 1384
Misses ? 1704
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid, thanks!
The only question is whether, going forward, we should try to use conda whenever possible instead of virtual environments and other solutions. As more and more of the tools we use are distributed with conda (and I'm thinking of ANTs as the most prominent example), we probably want CI and our Dockerfiles to leverage it more.
If we're running tests that require these as dependencies, then sure. We don't currently have any pytest-runnable tests that depend on ANTs, do we? |
No, that's why I think this PR can and should be merged. But for the future, I would lean towards standardizing the conda setup, even if we have to pay some increased installation price. Having a homogeneous setup across projects will help maintainability through time. |
Changes proposed in this pull request
I want to run pre-release tests on fMRIPrep to make sure that upcoming releases like numpy, nilearn or pybids aren't going to break things. GitHub actions seems the lightest-touch way of doing this.
Starting with stable tests. Will add pre-release if this works.Started with stable tests, added pre-release tests. Added a test to ensure that we exercise pybids.
Documentation that should be reviewed