ENH: Stop NeuroDebian dependency in Dockerfile #2578
Conversation
oesteban
force-pushed
the
fix/dockerfile-more-anaconda
branch
2 times, most recently
from
9e54756
to
2d3f4dc
Compare
either through conda or direct download
oesteban
force-pushed
the
fix/dockerfile-more-anaconda
branch
from
2d3f4dc
to
0953038
Compare
Dockerfile
Outdated
| mkl-service \ | ||
| mkl \ |
There was a problem hiding this comment.
The point of pinning these was to reduce the scope of rebuilds to inadvertently introduce sources of numeric variation. Has that changed?
There was a problem hiding this comment.
Has that changed?
Not really. We can still pin some specific versions after being able to build - but pinning with conda is not precisely smooth. I'm not against reintroducing pins on all dependencies.
Dockerfile
Outdated
| # ABI tags can interfere when running on Singularity | ||
| RUN strip --remove-section=.note.ABI-tag /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 | ||
| # RUN strip --remove-section=.note.ABI-tag /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 |
There was a problem hiding this comment.
Before we merge with this removed, let's push a docker/ branch and ask a user who was experiencing the problem (#2534) to verify that it doesn't return.
To my knowledge, affected users include @sameera2004 and @jbwexler.
There was a problem hiding this comment.
Yup. Alternatively, I can try to locate Qt5 (now installed by conda) and remove the tag anyways.
There was a problem hiding this comment.
Well, pushing a docker/ branch will make either task easier.
There was a problem hiding this comment.
|
I'll merge now to allow other PRs be executed. The ABI tag stripping has been restored, so it should not be an issue anymore. |
Codecov Report
@@ Coverage Diff @@
## master #2578 +/- ##
=======================================
Coverage 45.33% 45.33%
=======================================
Files 41 41
Lines 3121 3121
=======================================
Hits 1415 1415
Misses 1706 1706
Continue to review full report at Codecov.
|
either through conda or direct download
Changes proposed in this pull request
Documentation that should be reviewed