MAINT: Stage Python environment of Docker image from nipreps/miniconda #2581
Conversation
|
cc @eilidhmacnicol I think this is the way around the problems with the docker images you were experiencing. |
| ENV PATH="/opt/conda/bin:$PATH" \ | ||
| CPATH="/opt/conda/include:$CPATH" \ | ||
| LD_LIBRARY_PATH="/opt/conda/lib:$LD_LIBRARY_PATH" \ |
There was a problem hiding this comment.
This is going to cause pain for people reusing nipype working directories across 21.0.0rc's. I think it's okay, but we should make it part of the release notes.
There was a problem hiding this comment.
Well, I guess that's actually a good argument to push this kind of changes before the 21.0.0 release rather than postponing to 21.1.0, correct?
There was a problem hiding this comment.
i think it's fine to make the switch now
I'm not so sure this will help me, unfortunately. I think the issue that I was having was pulling an ubuntu image with the default call on an M1 Mac built an image with an arm64 architecture. The arm64 image had build problems before conda was installed (i.e. problems installing the dependencies for freesurfer, FSL and AFNI). Once I ran Similarly, |
| name: Pull nipreps/miniconda | ||
| command: | | ||
| set +e | ||
| docker pull localhost:5000/miniconda:1.2.0 |
There was a problem hiding this comment.
what's the reasoning for versioning as 1.2.0? Also I think the python version should be included in the tag
There was a problem hiding this comment.
what's the reasoning for versioning as
1.2.0?
Version history is on the repo, roughly I bumped the minor twice as I added new features. But there's no particular reason, so we could use any suggestions you find appropriate.
Also I think the python version should be included in the tag
Sure, we just need to add it in the tag when creating the release on GitHub.
This PR explores the possibility of sharing some base images across end-user preps.
Leveraging the fact that conda stuffs everything under the distribution's directory, that is particularly convenient to install all the dependencies we need related to Python and NodeJS with multi-stage builds, and also make the environment more consistent across preps.
The source of
nipreps/minicondais found at https://github.com/nipreps-containers/miniconda/blob/main/DockerfileI still believe that multi-stage builds are a neat solution to our build times, especially if we are going to start pruning out unused components of packages.