-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Replace initial FLIRT with mri_coreg, use -basescale 1 for FLIRT-BBR #2625
Conversation
- Avoid the issues with high-resolution anatomical data explained in nipreps#2591 - Improve consistency between running with `--fs-no-reconall` and without
- Disables `flirt` scaling of input transformation matrices, which may lead to issues with high-resolution T1w data (see nipreps#2591)
@mgxd We need to update the reports and boilerplate to indicate that we're using |
Once we get niworkflows passing, I'll kick off the release chain, but I don't expect we'll get to fmriprep until Monday. Depending on how long you think those updates will take, you can probably just do it here. |
Ah, niworkflows is going to be at least two hours to finish the mask regression tests. I'll see what I can get to by 5. |
Not really sure how to fix this in the citation boilerplate (from artifacts: Functional data preprocessing
: For each of the 1 BOLD runs found per subject (across all
tasks and sessions), the following preprocessing was performed.
Preprocessing of B0 inhomogeneity mappings
: A total of 1 fieldmaps were found available within the input
BIDS structure for this particular subject.
A deformation field to correct for susceptibility distortions was estimated
based on *fMRIPrep*'s *fieldmap-less* approach.
The deformation field is that resulting from co-registering the EPI reference
to the same-subject T1w-reference with its intensity inverted [@fieldmapless1;
@fieldmapless2].
Registration is performed with `antsRegistration`
(ANTs 2.3.3), and
the process regularized by constraining deformation to be nonzero only
along the phase-encoding direction, and modulated with an average fieldmap
template [@fieldmapless3].
First, a reference volume and its skull-stripped version were generated
from the shortest echo of the BOLD run using a custom
methodology of *fMRIPrep*.
[...] Pretty sure it should be
|
96bc805
to
c52206f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
==========================================
- Coverage 45.46% 45.43% -0.03%
==========================================
Files 41 41
Lines 3161 3163 +2
==========================================
Hits 1437 1437
- Misses 1724 1726 +2
Continue to review full report at Codecov.
|
@oesteban As the master of the literate workflows, your advice on how to rearrange the boilerplate text would be appreciated. |
I was looking into this earlier - from my understanding, order largely depends on the graph order, though |
I'm not sure this problem has been introduced here - we probably should get this merged and keep investigating why the boilerplate is garbled.
Agreed. |
No it wasn't introduced here. Was just interested in fixing it. I'm okay with merging this as is. |
Rebases #2607 on master.
Fast-tracked to get this into the next 21.0.0 RC. Need to figure out numpy failures in the docker image to patch 20.2.x.