Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 21.0.1 #2698

Merged
merged 4 commits into from
Jan 24, 2022
Merged

REL: 21.0.1 #2698

merged 4 commits into from
Jan 24, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 21, 2022

Preparation for the 21.0.1 bug-fix release.

Contributors found in git history not listed in Zenodo:

If you would like to be listed as contributors, please provide your preferred name, affiliation and ORCID.

Edit: Updated mailmap and found two contributors already listed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #2698 (80ef353) into maint/21.0.x (0caba88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           maint/21.0.x    #2698   +/-   ##
=============================================
  Coverage         46.69%   46.69%           
=============================================
  Files                44       44           
  Lines              3270     3270           
=============================================
  Hits               1527     1527           
  Misses             1743     1743           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0caba88...80ef353. Read the comment docs.

@theoschaefer
Copy link
Contributor

Preparation for the 21.0.1 bug-fix release.

Contributors found in git history not listed in Zenodo:

* @celprov

* @theoschaefer

* @josephmje and @marcbue (Also pinged on [REL: 20.2.7 #2697](https://github.com/nipreps/fmriprep/pull/2697); only need to respond to one.)

If you would like to be listed as contributors, please provide your preferred name, affiliation and ORCID.

Sure! I had already entered the two entries (Alex and me) below in the zenodo file (PR #2502) several months ago, but maybe I did something wrong.

   {
      "affiliation": "Max Planck Institute for Human Cognitive and Brain Sciences, Leipzig, Germany",
      "name": "Schaefer, Theo A.J.",
      "orcid": "0000-0003-4102-559X",
      "type": "Researcher"
    },
    {
      "affiliation": "Max Planck Institute for Human Cognitive and Brain Sciences, Leipzig, Germany",
      "name": "Nitsch, Alexander",
      "orcid": "0000-0002-5740-9451",
      "type": "Researcher"
    }

@effigies
Copy link
Member Author

I had already entered the two entries (Alex and me) below in the zenodo file (PR #2502) several months ago, but maybe I did something wrong.

Nope, you did it right; we just didn't update the mailmap so that our tools could make the association. Fixed.

@josephmje
Copy link
Contributor

My contribution was very minor so I'll hold off on being added to the Zenodo for now.

@effigies effigies merged commit 006c2a7 into maint/21.0.x Jan 24, 2022
@effigies effigies deleted the rel/21.0.1 branch January 24, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants