Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] ENH: Improve confound header names #634

Merged
merged 1 commit into from
Aug 5, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 1, 2017

@effigies
Copy link
Member Author

effigies commented Aug 1, 2017

While that fixes it, there is an issue for datasets too short to produce confounds, but with non-steady-state outliers, such as ds005/sub-01/func/*run-01*.bold. Not sure how I missed this. There's a fix over at nipy/nipype#2138, which I've tested on that dataset locally.

I'll update the pins here, so that Circle will build it...

@oesteban
Copy link
Member

oesteban commented Aug 1, 2017

Should I merge this already?

@effigies
Copy link
Member Author

effigies commented Aug 1, 2017

No. Need to merge into nipype and niworkflows first.

@effigies effigies changed the title ENH: Improve confound header names [WIP] ENH: Improve confound header names Aug 1, 2017
@oesteban
Copy link
Member

oesteban commented Aug 1, 2017 via email

@effigies
Copy link
Member Author

effigies commented Aug 2, 2017

Excerpted confounds.tsv:

tCompCor00 tCompCor05 aCompCor00 aCompCor05 NonSteadyStateOutlier00
0 0 0 0 1
-0.4371572005 0.0557365655 -0.3931056217 0.2711029978 0
0.0644078063 -0.5244772443 0.13139585 -0.0393245026 0
0.3763848735 0.2411832222 0.2838979808 -0.3508611558 0
0.3745648673 -0.0766074055 0.2799187512 -0.0620435332 0
0.1518852892 0.2507682694 0.3989339177 0.3213743293 0
-0.1056200975 0.1460221678 0.3054514479 0.2945456173 0
-0.0022437328 -0.1199075195 0.2638761357 -0.2511155202 0
0.3316998401 -0.2322500403 0.1232900596 -0.2069637969 0
0.1620694153 0.3295860188 -0.0552770858 0.1250341463 0
-0.1316354992 -0.1373579747 -0.1013527616 0.5480407703 0
-0.5190575626 0.0931088749 -0.3375762751 -0.1050603748 0
-0.2409135032 -0.0395117923 -0.2651946021 -0.1856786497 0
0.0516509609 0.3878416506 -0.2130329332 -0.0009426788 0
-0.0070883494 -0.4582866366 -0.1992427774 0.0164638213 0
-0.0689471074 0.084151844 -0.221982086 -0.3745714704 0

@oesteban @chrisfilo Do you want to have a look at the whole file to see if there are any other things to fix up while we're playing around here?

@effigies effigies changed the title [WIP] ENH: Improve confound header names [RTM] ENH: Improve confound header names Aug 4, 2017
@effigies
Copy link
Member Author

effigies commented Aug 5, 2017

Just a pin update. Taking nipype merge as go-ahead to merge.

@effigies effigies merged commit c0a0e8d into nipreps:master Aug 5, 2017
@effigies effigies deleted the pin/compcor_headers branch August 5, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants