[ENH] Strip reportlets out of full report #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
changed the title
|
Maybe |
effigies
reviewed
Dec 1, 2017
.circle/data/ds005_outputs.txt
Outdated
| @@ -45,6 +45,23 @@ ds005/out/fmriprep/sub-01/func/sub-01_task-mixedgamblestask_run-02_bold_space-MN | |||
| ds005/out/fmriprep/sub-01/func/sub-01_task-mixedgamblestask_run-02_bold_space-MNI152NLin2009cAsym_preproc.nii.gz | |||
| ds005/out/fmriprep/sub-01/func/sub-01_task-mixedgamblestask_run-02_bold_space-MNI152NLin2009cAsym_variant-smoothAROMAnonaggr_preproc.nii.gz | |||
| ds005/out/fmriprep/sub-01.html | |||
| ds005/out/fmriprep/sub-01/figures | |||
| ds005/out/fmriprep/sub-01/figures/_scratch_reportlets_fmriprep_sub-01_anat_sub-01_T1w_reconall.svg | |||
There was a problem hiding this comment.
Can we drop the _scratch_reportlets_fmriprep_?
Also, if this is going to be a derivative, I think it makes sense to apply some naming conventions that can eventually be standardized. For instance, perhaps the type can be _{static,anim}.svg indicating whether it's a static or animated image. Here are some examples, but feel free to reject any that you don't like.
Structural:
- reconall.svg -> surfaceoutline_static.svg
- t1_2_mni.svg -> normalization_anim.svg
- t1_seg.svg -> segmentation_static.svg
- t1_skull_strip.svg -> skullstrip_static.svg
Functional:
- acompcor.svg -> acompcor_static.svg
- bbr.svg -> registration_anim.svg
- bold_mask.svg -> skullstrip_static.svg
- syn_sdc.svg -> synsdc_anim.svg
- tcompcor.svg -> tcompcor_static.svg
There was a problem hiding this comment.
I totally agree with all of this. Would it be fine with you if we leave this comment for the next iteration over #478 ? Just to make all these changes more iteratively, and risk less to breaking reports.
oesteban
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first stab at #478. Requires nipreps/niworkflows#210 to be merged in first
The stripped svgs are stored in:
we can move it if you think that is not right.