FIX: Avert costly BIDSLayout.__repr__ calls when saving config
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing out the config file, the layout is printed out as a string. The object's ``__repr__`` shows a summary of subjects and tasks, etc. that for large datasets can be very costly. Rewriting the ``__repr__`` of the layout effectively removes runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout is printed out as a string when writing the config file. The object's
__repr__shows a summary of subjects and tasks, etc., which for large datasets can be very costly.Rewriting the layout's
__repr__effectively reduces runtime.Resolves: #1236.
cc/ @effigies