Fail for non-formatted code #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - name: Set up Python | |||
| uses: actions/setup-python@v5 | |||
| - run: pipx run ruff check mriqc/ | |||
| - run: pipx run ruff format --diff | |||
There was a problem hiding this comment.
This changed ruff check into ruff format. On purpose?
There was a problem hiding this comment.
I had missed it. Does format include check?
There was a problem hiding this comment.
No , ruff check and ruff format are different. I can add ruff check back in #1348.
There was a problem hiding this comment.
Also, do we want to apply ruff to mriqc/ only, or to the whole repository? I think applying ruff to the whole repository was a good move.
There was a problem hiding this comment.
Thanks for this, yes, please include these suggestions within #1348.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GitHub Actions workflow to fail if the code isn't formatted. This PR depends on #1273.