Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF/ENH: Rework workflow generation #219

Merged
merged 8 commits into from May 25, 2022
Merged

RF/ENH: Rework workflow generation #219

merged 8 commits into from May 25, 2022

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented May 23, 2022

  • Builds workflow / boilerplate within the same process, which will greatly simplify debugging.
  • Less warnings by default, but can be re-added setting the NIBABIES_SHOW_WARNINGS envvar to a true value.
  • Set OMP_NUM_THREADS envvar to 1 when constructing the workflow. This has been shown to greatly reduce VMS (see ENH: Add instrumentation to monitor resources mriqc#984)

@mgxd mgxd requested a review from oesteban May 23, 2022 22:12
@pep8speaks
Copy link

pep8speaks commented May 23, 2022 •
edited

Hello @mgxd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-24 12:34:34 UTC

@mgxd mgxd merged commit e8e9054 into nipreps:master May 25, 2022
@mgxd mgxd deleted the rf/build-workflow branch May 25, 2022 13:35
@mgxd mgxd added this to the 22.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban Awaiting requested review from oesteban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgxd @pep8speaks