enh: add oasis joint-fusion label atlas #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Feb 27, 2018
niworkflows/data/getters.py
Outdated
| @@ -22,7 +22,8 @@ | |||
| 'mni152_nlin_sym_las': ('57fa7fc89ad5a101e635eeef', '9c4c0cad2a2e99d6799f01abf4107f5a'), | |||
| 'mni152_nlin_sym_ras': ('57fa7fd09ad5a101df35eed0', '65d64ad5a980da86e7d07d95b3ed2ccb'), | |||
| 'mni_icbm152_linear': ('580705eb594d9001ed622649', '72be639e92532def7caad75cb4058e83'), | |||
| 'mni_icbm152_nlin_asym_09c': ('580705089ad5a101f17944a9', '002f9bf24dc5c32de50c03f01fa539ec') | |||
| 'mni_icbm152_nlin_asym_09c': ('580705089ad5a101f17944a9', '002f9bf24dc5c32de50c03f01fa539ec'), | |||
| 'oasis_dtk31_mni152': ('5a95995e91b689000ea221fe', '6eb144c5e3f5a375f23ffc3dc2d1cc2f') | |||
There was a problem hiding this comment.
Can you add a comma at the end here, so that future additions only affect the one line?
|
looks like a caching problem, perhaps needs to be restarted? |
|
Restarted, but not sure if that invalidates the cache. "Re-run without cache" doesn't seem to exist anymore... |
3 tasks
effigies
reviewed
Feb 27, 2018
niworkflows/data/getters.py
Outdated
| @@ -22,7 +22,8 @@ | |||
| 'mni152_nlin_sym_las': ('57fa7fc89ad5a101e635eeef', '9c4c0cad2a2e99d6799f01abf4107f5a'), | |||
| 'mni152_nlin_sym_ras': ('57fa7fd09ad5a101df35eed0', '65d64ad5a980da86e7d07d95b3ed2ccb'), | |||
| 'mni_icbm152_linear': ('580705eb594d9001ed622649', '72be639e92532def7caad75cb4058e83'), | |||
| 'mni_icbm152_nlin_asym_09c': ('580705089ad5a101f17944a9', '002f9bf24dc5c32de50c03f01fa539ec') | |||
| 'mni_icbm152_nlin_asym_09c': ('580705089ad5a101f17944a9', '002f9bf24dc5c32de50c03f01fa539ec'), | |||
| 'oasis_dtk31_mni152': ('5a95995e91b689000ea221fe', '6eb144c5e3f5a375f23ffc3dc2d1cc2f'), | |||
There was a problem hiding this comment.
I think you actually want dkt31, assuming it refers to "Desikan-Killiany-Tourville".
There was a problem hiding this comment.
looks like i fat fingered that, good catch
|
LGTM. @oesteban any concerns? |
satra
reviewed
Feb 28, 2018
| @@ -22,7 +22,8 @@ | |||
| 'mni152_nlin_sym_las': ('57fa7fc89ad5a101e635eeef', '9c4c0cad2a2e99d6799f01abf4107f5a'), | |||
| 'mni152_nlin_sym_ras': ('57fa7fd09ad5a101df35eed0', '65d64ad5a980da86e7d07d95b3ed2ccb'), | |||
| 'mni_icbm152_linear': ('580705eb594d9001ed622649', '72be639e92532def7caad75cb4058e83'), | |||
| 'mni_icbm152_nlin_asym_09c': ('580705089ad5a101f17944a9', '002f9bf24dc5c32de50c03f01fa539ec') | |||
| 'mni_icbm152_nlin_asym_09c': ('580705089ad5a101f17944a9', '002f9bf24dc5c32de50c03f01fa539ec'), | |||
| 'oasis_dkt31_mni152': ('5a95cd9591b689000ca5b6ab', 'e0bea438b9645c9e7c333a6edd859715'), | |||
There was a problem hiding this comment.
this was generated by registering the oasis template brainmask to the 2mm mni-asym template, and then applying the transform to the label atlas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.