MAINT: Switch to a setup.cfg-based setup
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
maint/setup_cfg
branch
from
c8dbb47
to
988929c
Compare
effigies
commented
Jul 11, 2019
effigies
force-pushed
the
maint/setup_cfg
branch
from
9e34c4a
to
afb9fcc
Compare
oesteban
reviewed
Jul 11, 2019
effigies
force-pushed
the
maint/setup_cfg
branch
2 times, most recently
from
6ae9c08
to
e741def
Compare
effigies
force-pushed
the
maint/setup_cfg
branch
from
e741def
to
c4c6bf7
Compare
effigies
commented
Jul 11, 2019
| python3 -m pip install dist/*.tar.gz | ||
| mkdir empty | ||
| cd empty | ||
| INSTALLED=$( python3 -c 'import niworkflows; print(niworkflows.__version__)' ) |
There was a problem hiding this comment.
This fails if we build and install from a wheel... I'm not sure why. Perhaps we need to upgrade wheel?
effigies
force-pushed
the
maint/setup_cfg
branch
from
cdb9ffb
to
7dbcdfe
Compare
|
@oesteban This should be set. |
oesteban
approved these changes
Jul 11, 2019
| python3 -m pip install dist/*.tar.gz | ||
| mkdir empty | ||
| cd empty | ||
| INSTALLED=$( python3 -c 'import niworkflows; print(niworkflows.__version__)' ) |
oesteban
changed the title
setup.cfg-based setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating installation methods and version stamping with Travis. Going to end up with a pretty big matrix (3 versions by 7 environments, at least), but for a project that a lot of our stuff depends on, I think it's worth it.
Closes #373.