Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Load file with mmap=False when modifying on-disk dtype #378

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

effigies
Copy link
Member

This causes a BusError reported in NeuroStars #4641.

@effigies effigies requested a review from oesteban July 18, 2019 19:00
@effigies effigies added the effort:low Estimated low effort task label Jul 18, 2019
@effigies effigies added this to the 0.10.1 milestone Jul 18, 2019
@effigies effigies added the impact:medium Estimated medium impact task label Jul 18, 2019
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #378 into master will increase coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   39.01%   39.66%   +0.64%     
==========================================
  Files          43       43              
  Lines        4788     4788              
==========================================
+ Hits         1868     1899      +31     
+ Misses       2920     2889      -31
Flag Coverage Δ
#reportlettests 100% <ø> (ø) ⬆️
#unittests 39.66% <100%> (+0.64%) ⬆️
Impacted Files Coverage Δ
niworkflows/interfaces/itk.py 38.88% <100%> (+10.49%) ⬆️
niworkflows/interfaces/utils.py 41.05% <0%> (+2.62%) ⬆️
niworkflows/interfaces/fixes.py 60% <0%> (+15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a37503...7ac8772. Read the comment docs.

@effigies
Copy link
Member Author

Looking into it more, this should resolve the issue with nipreps/fmriprep#1555 after all. I had forgotten we had fixed the other one of these a bit ago.

@effigies
Copy link
Member Author

@oesteban This is all set and the case is covered.

@oesteban oesteban merged commit 9a4c24a into master Jul 22, 2019
@oesteban oesteban deleted the fix/buserror branch July 22, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:low Estimated low effort task impact:medium Estimated medium impact task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants