-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Bring EPI brain extraction tests from fMRIPrep #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will eventually show up |
Oh, there they are. Circle sometimes seems to only make them appear when complete, so I wanted a quick way to click and see, since they're under your user, not the poldracklab user. |
I think you're missing a |
@effigies thumbs-up? |
Since this is not fMRIPrep proper, I'll go take the leap. Hopefully not waiting on your review does not backfire. |
oesteban
force-pushed
the
masks/bring-fmriprep-tests
branch
from
July 25, 2019 21:53
59c4424
to
62f746a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new build job to the CircleCI workflow to tests regressions on the EPI masking workflows migrated from fMRIPrep (#362).
The infrastructure and tests are replicated from fMRIPrep.
The PR makes CircleCI ignore these tests (branches and tags) except for
master
and branches with namemasks?/*
to minimize churn.Incidentally, minor fixes to #362 are included.
Closes #371