Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Bring EPI brain extraction tests from fMRIPrep #380

Merged
merged 6 commits into from
Jul 25, 2019

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Jul 25, 2019

This PR adds a new build job to the CircleCI workflow to tests regressions on the EPI masking workflows migrated from fMRIPrep (#362).

The infrastructure and tests are replicated from fMRIPrep.

The PR makes CircleCI ignore these tests (branches and tags) except for master and branches with name masks?/* to minimize churn.

Incidentally, minor fixes to #362 are included.

Closes #371

@effigies
Copy link
Member

@oesteban
Copy link
Member Author

They will eventually show up

@effigies
Copy link
Member

Oh, there they are. Circle sometimes seems to only make them appear when complete, so I wanted a quick way to click and see, since they're under your user, not the poldracklab user.

@effigies
Copy link
Member

I think you're missing a niworkflows/func/tests/__init__.py.

@oesteban
Copy link
Member Author

@effigies thumbs-up?

@oesteban
Copy link
Member Author

Since this is not fMRIPrep proper, I'll go take the leap. Hopefully not waiting on your review does not backfire.

@oesteban oesteban merged commit cc8aa85 into nipreps:master Jul 25, 2019
@oesteban oesteban deleted the masks/bring-fmriprep-tests branch July 25, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests of EPI masks from fMRIPrep
2 participants