Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update nibabel to 3.0.0rc1 #439

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Dec 11, 2019

No description provided.

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     maint: pin nibabel 3.0.0rc1

Powered by Pull Assistant. Last update f68b771 ... f68b771. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #439 into master will decrease coverage by 4.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   60.13%   56.12%   -4.02%     
==========================================
  Files          57       57              
  Lines        5459     5459              
  Branches      646      646              
==========================================
- Hits         3283     3064     -219     
- Misses       2133     2341     +208     
- Partials       43       54      +11
Flag Coverage Δ
#masks ?
#reportlettests 100% <ø> (ø) ⬆️
#unittests 43.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
niworkflows/func/tests/test_util.py 0% <0%> (-100%) ⬇️
niworkflows/func/util.py 28% <0%> (-52%) ⬇️
niworkflows/interfaces/fixes.py 47.05% <0%> (-39.22%) ⬇️
niworkflows/engine/workflows.py 26.31% <0%> (-15.79%) ⬇️
niworkflows/interfaces/registration.py 52.15% <0%> (-9.92%) ⬇️
niworkflows/viz/utils.py 74.09% <0%> (-7.52%) ⬇️
niworkflows/interfaces/utils.py 40.71% <0%> (-7.39%) ⬇️
niworkflows/interfaces/ants.py 67.7% <0%> (-6.25%) ⬇️
niworkflows/interfaces/images.py 47.47% <0%> (-4.78%) ⬇️
niworkflows/interfaces/masks.py 62.87% <0%> (-2.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3f122...f68b771. Read the comment docs.

@effigies
Copy link
Member

Didn't see any DeprecationWarnings in doc build or pytest outputs.

@effigies effigies merged commit ce82d76 into nipreps:master Dec 11, 2019
@mgxd mgxd deleted the maint/nibabel3 branch December 11, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants