-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add cache to SpatialReferences #453
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
I'll leave this here @oesteban |
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 45.98% 57.38% +11.4%
==========================================
Files 61 61
Lines 6048 6113 +65
Branches 0 710 +710
==========================================
+ Hits 2781 3508 +727
+ Misses 3267 2547 -720
- Partials 0 58 +58
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we should accept several checkpoints, instead of raising error. (and provide access to earlier timepoints).
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
cached
property to allow checkpointingspaces
.SpatialReferences
standard spaces class attribute private