Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add option to bypass twopass in AFNI RobustAverage #801

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

eilidhmacnicol
Copy link
Collaborator

Occasionally, the -twopass option in AFNI's 3dVolReg overshoots the mark, particularly when two volumes are already quite close in space (e.g. when pepolar "blip" images are acquired immediately after each other with the same slice package, but with the phase encoding direction reversed).

When using RobustAverage to merge two blip volumes , the second image is displaced >10mm on the second pass, giving a terrible average, while with only one pass the displacement is ~1mm.

This PR gives the option to bypass the second pass and stick to just one. The default is True for backwards compatibility. WDYT?

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b7d72b8) 62.27% compared to head (1d7070c) 62.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   62.27%   62.28%           
=======================================
  Files          49       49           
  Lines        5967     5968    +1     
  Branches      883      883           
=======================================
+ Hits         3716     3717    +1     
  Misses       2071     2071           
  Partials      180      180           
Impacted Files Coverage Δ
niworkflows/interfaces/images.py 54.95% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies merged commit 9905f90 into nipreps:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants