Add ignore_initial_volumes param to ConfoundsCorrelationPlot
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
approved these changes
Dec 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
=======================================
Coverage 60.95% 60.96%
=======================================
Files 55 55
Lines 6557 6558 +1
Branches 954 954
=======================================
+ Hits 3997 3998 +1
Misses 2374 2374
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@tsalo Can you duplicate this in nireports? https://github.com/nipreps/nireports/blob/main/nireports/interfaces/nuisance.py |
|
Can do! |
|
😱 I didn't actually use the parameter in this PR!!! |
This was referenced Dec 11, 2023
effigies
pushed a commit
to nipreps/fmriprep
that referenced
this pull request
Dec 13, 2023
Closes #2614 and is related to nipreps/niworkflows#843. ## Changes proposed in this pull request - Feed `skip_vols` into confounds correlation plot. Since niworkflows is pinned to `master` in `pyproject.toml`, the new parameter from nipreps/niworkflows#843 can be used without waiting for a niworkflows release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nipreps/fmriprep#2614. Once this is merged and there's a new release, I will open a PR to fMRIPrep.
Changes proposed:
ignore_initial_volumesparameter to theConfoundsCorrelationPlotinterface.ignore_initial_volumesparameter to theconfounds_correlation_plotfunction.