Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add a preprocessing pipeline for SDC-SyN #184

Merged
merged 16 commits into from
Mar 5, 2021

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Feb 6, 2021

Brings the preprocessing for SyN back, leveraging the new reference
workflow from NiWorkflows.

Resolves: #183.

@pep8speaks
Copy link

pep8speaks commented Feb 10, 2021

Hello @oesteban, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 sdcflows.

Comment last updated at 2021-03-04 19:01:53 UTC

@oesteban oesteban force-pushed the enh/syn-preprocessing-wf branch 3 times, most recently from 5f871ee to 822d9e9 Compare March 2, 2021 20:48
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #184 (77d7cee) into master (f3c96b0) will decrease coverage by 2.71%.
The diff coverage is 75.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   96.96%   94.25%   -2.72%     
==========================================
  Files          23       23              
  Lines        1482     1618     +136     
  Branches      178      188      +10     
==========================================
+ Hits         1437     1525      +88     
- Misses         23       66      +43     
- Partials       22       27       +5     
Flag Coverage Δ
travis 88.99% <51.56%> (-5.34%) ⬇️
unittests 94.11% <75.52%> (-2.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/interfaces/brainmask.py 56.25% <42.85%> (-43.75%) ⬇️
sdcflows/workflows/fit/syn.py 86.02% <80.85%> (-13.98%) ⬇️
sdcflows/interfaces/utils.py 98.29% <97.77%> (-0.50%) ⬇️
sdcflows/workflows/base.py 100.00% <100.00%> (ø)
sdcflows/workflows/outputs.py 93.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c96b0...77d7cee. Read the comment docs.

@oesteban oesteban marked this pull request as ready for review March 5, 2021 07:27
@oesteban oesteban merged commit de010cc into master Mar 5, 2021
@oesteban oesteban deleted the enh/syn-preprocessing-wf branch March 5, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a preprocessing pipeline for SDC-SyN
2 participants