Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use subject root to resolve IntendedFor paths #228

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 5, 2021

It looks like we'd resolved this once with intended_root, but the root is always the subject folder.

Closes #227.

@effigies effigies added this to the 2.0.7 milestone Sep 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #228 (ab24b17) into master (592cacc) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   93.53%   93.66%   +0.12%     
==========================================
  Files          24       24              
  Lines        1671     1673       +2     
  Branches      192      191       -1     
==========================================
+ Hits         1563     1567       +4     
+ Misses         82       81       -1     
+ Partials       26       25       -1     
Flag Coverage Δ
travis 88.94% <100.00%> (?)
unittests 93.52% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdcflows/utils/wrangler.py 100.00% <100.00%> (ø)
sdcflows/utils/bimap.py 100.00% <0.00%> (ø)
sdcflows/fieldmaps.py 99.40% <0.00%> (+0.01%) ⬆️
sdcflows/transform.py 97.61% <0.00%> (+0.02%) ⬆️
sdcflows/interfaces/bspline.py 93.71% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592cacc...ab24b17. Read the comment docs.

bids_id='auto_...')]

>>> find_estimators(
... layout=layouts['dsB'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test reproduced #227. Used ellipses because I had to comment out the datalad datasets to test. I assume it's okay to leave them there.

@effigies effigies merged commit 1620310 into nipreps:master Sep 7, 2021
@effigies effigies deleted the fix/subject_root branch September 7, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with version 21.0.0rc0
3 participants