Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Chunk B-Spline approximation by grid levels #300

Closed
wants to merge 2 commits into from

Conversation

oesteban
Copy link
Member

No description provided.

@effigies
Copy link
Member

effigies commented Dec 2, 2022

This is working on the original EPI for me, with no down-sampling (since #301 is not merged into this branch). It's running in reasonable time (from 12 hours down to 6 minutes) and the estimate looks sensible. Waiting for it to finish and will post screenshots of the final report.

Will then try resolving merge conflicts and see if downsampling + multi-stage fitting continues to work as well or better.

@effigies
Copy link
Member

effigies commented Dec 2, 2022

Well, it's better than a checkerboard, but it doesn't look great.

Screenshot from 2022-12-02 12-03-20
Screenshot from 2022-12-02 12-03-36
Screenshot from 2022-12-02 12-03-50
Screenshot from 2022-12-02 12-03-57

@oesteban
Copy link
Member Author

I'm not very convinced about this. Compared to subsampling the input, this doesn't really make a dent to the memory utilization. Probably we can close this for now and retake the idea in the future.

@oesteban oesteban closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants