-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Use ANTs DenoiseImage before conforming anatomical images #337
Conversation
b057d95
to
a8c70ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall this is a nice addition.
I don't suspect it will add too much (in nibabies it takes about ~4mins) but have you tried to see how it affects the runtime of any test data?
One conceptual question - will this have any effect on confounds?
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 28.49% 28.47% -0.03%
==========================================
Files 19 19
Lines 1351 1352 +1
Branches 196 196
==========================================
Hits 385 385
- Misses 952 953 +1
Partials 14 14
☔ View full report in Codecov by Sentry. |
The impact on confounds would be in the definition of white matter/CSF ROIs, if those change. In subjects where the segmentations are kind of salt-and-pepper, we might end up with larger ROIs for those and CompCor. I did run on some test data and it took ~40sec on 16 cores. So should be <3min on 4 cores. |
So the output of ANTs DenoiseImage is used for recon-all, right? does this mean that using an existing output of recon-all for smriprep could lead to a very different result? is this version of smriprep already in fmriprep? |
This is in 23.1.x. fMRIPrep has always done FreeSurfer a little differently. We have passed INU-corrected T1w images and BOLD masks pre-computed by If you would like to use vanilla FreeSurfer, pre-run it and pass it to fMRIPrep with |
Closes #22.