RF: Break up surface workflows for easier mix-and-match in fMRIPrep #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
rf/split_surface_workflows
branch
from
5181632
to
0ac6ec9
Compare
RF: Update normalizer to rename graymid to midthickness
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #360 +/- ##
==========================================
- Coverage 53.65% 44.65% -9.00%
==========================================
Files 22 22
Lines 1627 1666 +39
Branches 214 225 +11
==========================================
- Hits 873 744 -129
- Misses 686 853 +167
- Partials 68 69 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
rf/split_surface_workflows
branch
3 times, most recently
from
c8d6cee
to
7c82f55
Compare
effigies
force-pushed
the
rf/split_surface_workflows
branch
from
7c82f55
to
8092b24
Compare
|
This is ready for review. |
mgxd
approved these changes
Aug 28, 2023
I think it should be pretty straightforward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have no effect on current outputs, but:
surface_recon_wf, which then needs a sync function to ensure that downstream nodes don't try to extract surfaces before midthickness is present.Does not need immediate merge. Will probably do more.