Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Save msm registration sphere as desc-msm_sphere.surf.gii #365

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 6, 2023

Follow-up to #358 in smriprep-next. This continues to save the initial space-fsLR_desc-reg_sphere.surf.gii and adds space-fsLR_desc-msm_sphere.surf.gii.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +27.63% 🎉

Comparison is base (b065045) 31.49% compared to head (db014df) 59.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##             next     #365       +/-   ##
===========================================
+ Coverage   31.49%   59.13%   +27.63%     
===========================================
  Files          21       26        +5     
  Lines        1762     1845       +83     
  Branches      233      235        +2     
===========================================
+ Hits          555     1091      +536     
+ Misses       1194      698      -496     
- Partials       13       56       +43     
Flag Coverage Δ
ds005 ∅ <ø> (?)
ds054 46.82% <0.00%> (?)
pytest 37.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
smriprep/workflows/anatomical.py 44.73% <0.00%> (+32.61%) ⬆️
smriprep/workflows/outputs.py 53.98% <0.00%> (+38.28%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit f6b842f into nipreps:next Sep 7, 2023
9 of 10 checks passed
@effigies effigies deleted the enh/save-msmreg branch September 7, 2023 03:23
@effigies effigies added the next label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant