FIX: invert result of skull-strip check in auto mode #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 28 28
Lines 2042 2042
Branches 240 240
=======================================
Hits 1572 1572
Misses 438 438
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
psadil
changed the title
effigies
approved these changes
Nov 29, 2023
effigies
pushed a commit
that referenced
this pull request
Dec 8, 2023
effigies
added a commit
that referenced
this pull request
Mar 20, 2024
0.14.0 (March 11, 2024) New feature release in the 0.14.x series. This release restores correct handling of cohort identifiers in templates. A feature release is warranted due to changes in the workflow structure. * FIX: Fetch templates during workflow construction (#418) * FIX: Re-add cohort identifier to template name (#416) * FIX: Repair FreeSurfer Dependency in Dockerfile (tcsh) (#404) * FIX: Invert result of skull-strip check in auto mode (#402) * STY: Adopt ruff for linting and formatting (#397) * CHORE: Update ruff, ignore certain rules (#419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401
By default, skull-stripping was conditional on a check whose logic was reversed in 0.13.1 (that is, run when all T1w images have had skulls stripped). This fixes the inversion.