-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Fetch templates during workflow construction #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
===========================================
+ Coverage 62.91% 78.59% +15.67%
===========================================
Files 24 30 +6
Lines 1912 2088 +176
Branches 242 248 +6
===========================================
+ Hits 1203 1641 +438
+ Misses 676 415 -261
+ Partials 33 32 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Mar 6, 2024
effigies
approved these changes
Mar 7, 2024
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
c783a7e
to
9f13a86
Compare
mgxd
added a commit
to nipreps/fmriprep
that referenced
this pull request
Mar 7, 2024
Ensures the proper resolution templates are fetched following nipreps/smriprep#418
effigies
added a commit
that referenced
this pull request
Mar 20, 2024
0.14.0 (March 11, 2024) New feature release in the 0.14.x series. This release restores correct handling of cohort identifiers in templates. A feature release is warranted due to changes in the workflow structure. * FIX: Fetch templates during workflow construction (#418) * FIX: Re-add cohort identifier to template name (#416) * FIX: Repair FreeSurfer Dependency in Dockerfile (tcsh) (#404) * FIX: Invert result of skull-strip check in auto mode (#402) * STY: Adopt ruff for linting and formatting (#397) * CHORE: Update ruff, ignore certain rules (#419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses nipreps/fmriprep#3240, a few changes were necessary:
templateflow.api.get()
)sloppy
parameter toinit_template_iterator_wf
, since the T1w/brain mask's resolution (used inSpatialNormalization
) depends on this parameter as well.I stripped out most of the logic in
TemplateFlowSelect
to avoid duplicating the behavior, since it is essentially linked.