Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Time-label consistency over time #131

Merged
merged 3 commits into from
May 6, 2015

Conversation

christianbrodbeck
Copy link
Collaborator

Mayavi's default bahavior is to change the text size when the number of characters changes, which looks strange in a movie (see before). This PR tries to fix this tentatively by using a constant font size and right-aligning the label (see after). I don't know how much of this should be exposed in Brain.add_data(), maybe at least the font size?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 72.56% when pulling a2fe975 on christianbrodbeck:timelabel into b8b8c10 on nipy:master.

@larsoner
Copy link
Contributor

larsoner commented May 6, 2015

This will break backward compatibility a bit, since it will change how the labels get plotted. I think I'm okay with it in this case, though. @agramfort WDYT?

@christianbrodbeck
Copy link
Collaborator Author

Yes I was considering exposing the old default as an argument, but since the old default had this strange effect whenever the number of digits changed maybe something more useful can be exposed...

@agramfort
Copy link
Contributor

it's more a bug fix so I am fine with it. You use more these features than me anyway :)

@christianbrodbeck
Copy link
Collaborator Author

Ok, I exposed the font size for the label. Do you want more options?

@larsoner
Copy link
Contributor

larsoner commented May 6, 2015

Looks good, we can add more later if we need them

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 72.56% when pulling 188c833 on christianbrodbeck:timelabel into b8b8c10 on nipy:master.

larsoner added a commit that referenced this pull request May 6, 2015
ENH:  Time-label consistency over time
@larsoner larsoner merged commit bcdd7a0 into nipy:master May 6, 2015
@larsoner
Copy link
Contributor

larsoner commented May 6, 2015

Thanks again @christianbrodbeck

@christianbrodbeck christianbrodbeck deleted the timelabel branch February 9, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants