-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Time-label consistency over time #131
Conversation
This will break backward compatibility a bit, since it will change how the labels get plotted. I think I'm okay with it in this case, though. @agramfort WDYT? |
Yes I was considering exposing the old default as an argument, but since the old default had this strange effect whenever the number of digits changed maybe something more useful can be exposed... |
it's more a bug fix so I am fine with it. You use more these features than me anyway :) |
Ok, I exposed the font size for the label. Do you want more options? |
Looks good, we can add more later if we need them |
ENH: Time-label consistency over time
Thanks again @christianbrodbeck |
Mayavi's default bahavior is to change the text size when the number of characters changes, which looks strange in a movie (see before). This PR tries to fix this tentatively by using a constant font size and right-aligning the label (see after). I don't know how much of this should be exposed in
Brain.add_data()
, maybe at least the font size?