Show stderr when mri_vol2surf fails #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
force-pushed
the
project_volume_data_stderr
branch
from
73f27f0
to
e64a4e9
Compare
|
Fine by me. Looks like we need to fix CIs, I'll see if it's easy |
agramfort
reviewed
Jan 27, 2017
| @@ -225,7 +225,7 @@ def project_volume_data(filepath, hemi, reg_file=None, subject_id=None, | |||
| out = p.returncode | |||
| if out: | |||
| raise RuntimeError(("mri_vol2surf command failed " | |||
| "with command-line: ") + " ".join(cmd_list)) | |||
There was a problem hiding this comment.
that's sad not to show the command anymore. I would show both...
There was a problem hiding this comment.
The command gets printed here either way: https://github.com/nipy/PySurfer/pull/172/files#diff-bd3cabf83a69fe1b0d92a1df82fc1241R222
|
ok +1 for merge then provided we fix travis :) |
larsoner
force-pushed
the
project_volume_data_stderr
branch
from
e64a4e9
to
a81ebec
Compare
|
I'll rebase this now that Travis works again and merge if it's good to go |
|
Thanks @mwaskom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to debug problems when using
project_volume_data. Not sure why we were just printing the command line before (which gets printed anyway).Closes #171.