CI: Update test workflow with narrower job spec, more Python versions, concurrency #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
commented
Mar 27, 2023
Comment on lines
418
to
425
|
|
||
| wp = [lb_frac, ub_frac] | ||
|
|
||
| ws = [np.max([lb_frac - 0.1, 0]), | ||
| np.min([ub_frac + 0.1, 1.0])] | ||
| ws = [np.max([lb_frac - 0.1, 0.001]), | ||
| np.min([ub_frac + 0.1, 0.999])] | ||
|
|
||
| # For the lowpass: | ||
| elif lb_frac == 0: |
There was a problem hiding this comment.
This patch is required by scipy/scipy#15092. I'm not sure if it's the right patch though.
effigies
commented
Mar 28, 2023
|
|
||
| NFFT = 256 | ||
| Fs = 1.0 | ||
| noverlap = NFFT / 2 | ||
| noverlap = NFFT // 2 |
There was a problem hiding this comment.
Not sure when float noverlap stopped being okay, but given this is always 128, this seems fine.
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing. Starting by just updating config.