Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add per-volume transforms as single transform in chain #226

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

effigies
Copy link
Member

I believe 9772710 caused TransforrmChain to start treating LinearTransformMappings as Iterables to decompose. Thus, I was getting transform chains 303 transforms long instead of 4 long.

Here is a regression test that fails before the patch and passes after the patch.

I believe this resolves the issues in fMRIPrep/fMRIPost.

cc @tsalo

@effigies effigies changed the title FIX: Chain detection FIX: Do not treat iterable transforms as iterables of transforms when adding to a chain Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (e9b46cf) to head (7bc22c5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          15       15           
  Lines        1756     1758    +2     
  Branches      328      329    +1     
=======================================
+ Hits         1664     1666    +2     
  Misses         76       76           
  Partials       16       16           
Flag Coverage Δ
unittests 94.65% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 40724fc into nipy:master Sep 21, 2024
16 checks passed
@effigies effigies deleted the fix/chain_detection branch September 21, 2024 13:24
@effigies effigies changed the title FIX: Do not treat iterable transforms as iterables of transforms when adding to a chain FIX: Add per-volume transforms as single transform in chain Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant