Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in parsing case-sensitive Id key #1

Merged
merged 1 commit into from
Jun 7, 2014

Conversation

stanhu
Copy link

@stanhu stanhu commented Jun 7, 2014

This was resulting in an invalid container ID in docker-plugin.

(see: http://docs.docker.io/reference/api/docker_remote_api_v1.0)

This was resulting in an invalid container ID in docker-plugin.

(see: http://docs.docker.io/reference/api/docker_remote_api_v1.0)
magnayn added a commit that referenced this pull request Jun 7, 2014
Fix error in parsing case-sensitive Id key
@magnayn magnayn merged commit dae4338 into nirima:master Jun 7, 2014
@magnayn
Copy link

magnayn commented Jun 7, 2014

Thanks!

@magnayn
Copy link

magnayn commented Jun 7, 2014

Hmm - this isn't as it seems. On my docker hosts, I definitely am getting ID returned in /json

3625 > GET http://192.168.111.5:4243/containers/6189c1df4ae46e2b19c8aadf52e4e8b7e9b86e27b96d0eaaa66987ba0f10dc8a/json

Jun 04, 2014 2:27:16 PM org.glassfish.jersey.filter.LoggingFilter log
INFO: 33626 * Client response received on thread jenkins.util.Timer [kpelykh#10]
33626 < 200
33626 < Content-Length: 1736
33626 < Content-Type: application/json
33626 < Date: Wed, 04 Jun 2014 14:27:19 GMT
{"ID":"6189c1df4ae46e2b19c8aadf52e4e8b7e9b86e27b96d0eaaa66987ba0f10dc8a","Created":"2014-06-04T13:54:44.021768889Z","Path":"/usr/sbin/sshd","Args":["-D"],"Config":{"Hostname":"6189c1df4ae4","Domainname":"","User":"","Memory":0,"MemorySwap":0,"CpuShares":0,"AttachStdin":false,"AttachStdout":false,"AttachStderr":false,"PortSpecs":null,"ExposedPorts":{"22/tcp":{}},"Tty":true,"OpenStdin":true,"StdinOnce":true,"Env":["HOME=/","PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"],"Cmd":["/usr/sbin/sshd","-D"],"Dns":["192.168.111.252"],"Image":"192.168.111.28:5000/jenkins-slave","Volumes":null,"VolumesFrom":"","WorkingDir":"","Entrypoint":null,"NetworkDisabled":false,"OnBuild":null},"State":{"Running":true,"Pid":9491,"ExitCode":0,"StartedAt":"2014-06-04T13:54:44.202418006Z","FinishedAt":"0001-01-01T00:00:00Z","Ghost":false},"Image":"b3b7dd89095342a34988f648eccc3f3ba24779c1fd2770d0f430f875a85e5baa","NetworkSettings":{"IPAddress":"172.17.0.5","IPPrefixLen":16,"Gateway":"172.17.42.1","Bridge":"docker0","PortMapping":null,"Ports":{"22/tcp":[{"HostIp":"0.0.0.0","HostPort":"49403"}]}},"ResolvConfPath":"/var/lib/docker/containers/6189c1df4ae46e2b19c8aadf52e4e8b7e9b86e27b96d0eaaa66987ba0f10dc8a/resolv.conf","HostnamePath":"/var/lib/docker/containers/6189c1df4ae46e2b19c8aadf52e4e8b7e9b86e27b96d0eaaa66987ba0f10dc8a/hostname","HostsPath":"/var/lib/docker/containers/6189c1df4ae46e2b19c8aadf52e4e8b7e9b86e27b96d0eaaa66987ba0f10dc8a/hosts","Name":"/drunk_pike","Driver":"aufs","ExecDriver":"native-0.1","Volumes":{},"VolumesRW":{},"HostConfig":{"Binds":null,"ContainerIDFile":"","LxcConf":null,"Privileged":false,"PortBindings":{"22/tcp":[{"HostIp":"0.0.0.0","HostPort":"49403"}]},"Links":null,"PublishAllPorts":false}}

@stanhu
Copy link
Author

stanhu commented Jun 7, 2014

What version of Docker are you using?

@magnayn
Copy link

magnayn commented Jun 8, 2014

Many versions, but all <= 0.10.

If you search the docker issues list, it's acknowledged that the ID -> Id change is a breaking one.

I've adjusted jDocker so it'll cope with both, which hopefully ought to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants