Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard to lint src code #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Johann-S
Copy link
Contributor

@Johann-S Johann-S commented Apr 1, 2019

Hi @nirtz89,

This PR add standard as a linter, currently it lint only your source code.

Maybe you don't want this linter, so feel free to close this PR 👍

@swiftmatt
Copy link
Contributor

I had actually planned on working on implementing a linter in the near future, albeit, eslint as opposed to standardjs.

standardjs has some rules that conflict heavily with the author's original work. The FAQ also claims many benefits, including "No configuration", "Auto Formatting Code", "Catching style issues & programmer errors early". Any sort of linter should perform the last two points. Not having to submit a config to linter sounds great on paper. However, it's heavily opinionated in many controversial areas, without the ability to disable or override these rules.

Of course the decision lies with the author. I would agree that a linter is a must, just not this linter. If zero config is the goal, extending any popular eslint config allows a quick and easy starting point, with the ability to override as needed.

If this linter is chosen, however, you should include the other .js files in this repo, reformatted, as part of your PR.

@Johann-S
Copy link
Contributor Author

Johann-S commented Apr 2, 2019

It's just a proposal 👍

But yes if @nirtz89 aggreed for this linter I'll lint the other JS files 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants