Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the outside of Israel points #1

Merged
merged 7 commits into from
Aug 27, 2013
Merged

Conversation

alonisser
Copy link
Collaborator

besides the point: I suspect we use a different version of requests (I use 1.2.3) since I'm got mistakes from the code calling r.json instead of r.json() maybe a different version of python (I'm running on py2.7) , not explict tuple return etc. I changed the code to work (at least with my config)

@niryariv
Copy link
Owner

github can't single-click-merge this, so i'll handle that tomorrow morning

  • meanwhile added you as collaborator so you can push directly to the
    project, your python is way better than mine :)

On Tue, Aug 27, 2013 at 1:29 AM, Alonisser notifications@github.com wrote:

besides the point: I suspect we use a different version of requests (I use
1.2.3) since I'm got mistakes from the code calling r.json instead of
r.json() maybe a different version of python (I'm running on py2.7) , not
explict tuple return etc. I changed the code to work (at least with my

config)

You can merge this Pull Request by running

git pull https://github.com/alonisser/tiptipa master

Or view, comment on, or merge it at:

#1
Commit Summary

  • added a requirements file, since I suspect we don't use the same
    version of requests, and the code works differently with requests.json
  • modified readme to reflect changes
  • the previous all_station file, I think the current is better
  • fixed errors with accessing json function as attribute(maybe we use
    a different requests version?) added a function to check if the point is in
    Israel, only points in Israel get added to the geojson, the rest appended
    to errors.txt
  • I think this version is fixed
  • changes to show the correct geojson, should change back after pull
    request is merged
  • no palestine

File Changes

Patch Links:

@niryariv niryariv merged commit 22574b9 into niryariv:master Aug 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants