secular: refactor A.4 GNSS time-series plots #41
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@yunjunz When did you change MintPy to have the |
|
It was committed about a month ago (insarlab/MintPy#828), after the last release of 1.4.1. I plan to release version 1.5.0 in ~1 month to include this feature. I have completely migrated to the version with |
|
Can we add some code to work with the 1.4.1 release that is installed on the OpenSARLab servers? The Solid Earth ATBD review kickoff is scheduled for Nov. 1. |
|
Considering that the ATBD development is mostly done, we should not need the development version of mintpy anymore. Thus, one simple way is to use the conda-installed version of mintpy, with a fixed version number, similar to what we have done for gdal. If so, I will revert some of the changes in this PR, to work with mintpy-1.4.1 only. What do you think? |
|
Yes, I think it would be better to stick with the released version for the review. Does that mean that we also need to change the installation instructions? |
|
Yes, a little bit. I will try to update the PR for this later tonight. |
+ refactor the A.4 section: - simplify InSAR/GNSS reading by leveraging mintpy func - remove the un-meaningful velocity plot, which is extensively shown in the sections above - auto grab insar time-series filename based on template config. + remove unused module imports + sort module import based on standard practice for coseismic/secular/transient notebooks
This PR includes the following changes:
For the 3 notebooks under
methods/:update mintpy imports usage to the latest dev version[reverted]For the
methods/secular/only: